Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6101 closed defect (fixed)

Address comments regarding detection what output calls should be silenced.

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Core Keywords:
Cc: hfiguiere, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Wladimir Palant 2017/11/28 12:59:40
1) Inserting unescaped strings into a regular expression is a footgun (consider dots or question marks). If anything, the regular expression should be used to extract the message, then you should use regular string comparison.

2) Parsing string representation of errors isn't a good idea either, it can change. You have an Error object here, just look at the error.message property.

Change History (2)

comment:1 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 2 years ago by hfiguiere

Was fixed as a follow up to issue #6090

(I missed that this bug had been filed)

Note: See TracTickets for help on using tickets.