Opened 9 months ago

Closed 8 months ago

#6104 closed defect (fixed)

Minified code in help center repository

Reported by: juliandoucette Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: ire, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29624561

Description (last modified by juliandoucette)

Environment

  • help.eyeo.com

How to reproduce

  • See /static/js/vendor

Observed behaviour

  • See minified code

Expected behaviour

  • Code should be minified and source mapped via build process
  • Uncompressed versions should be available in production e.g. "main.min.css" and "main.css"
  • Dependencies should be managed by npm and excluded from source code repository
  • Make license information machine readable (https://www.gnu.org/software/librejs/free-your-javascript.html)

Let's not fall into The JavaScript Trap.

Change History (5)

comment:1 Changed 9 months ago by juliandoucette

  • Description modified (diff)

comment:2 Changed 9 months ago by ire

  • Owner set to ire
  • Ready set

comment:3 Changed 9 months ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 8 months ago by abpbot

A commit referencing this issue has landed:
Issue 6104 - Minified code in help center repository

comment:5 Changed 8 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.