Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6110 closed defect (fixed)

New options page does not display correctly in Chrome 49-51

Reported by: Ross Assignee: kzar
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: wspee, greiner, kzar, sebastian, saroyanm Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29625598/

Description

Environment

adblockplusui / 200:98dd77c2b086
Chrome 49 / 51 / Windows 7

Looks fine in Chrome 52+

How to reproduce

  1. Clone/update adblockplusui repo.
  2. Run the test_server.py script.
  3. Navigate to the desktop-options page served.

Observed behaviour

None of the text is present, all of the UI is collapsed and several errors about symbol.iterator are displayed in the console.

Expected behaviour

The new options page to display correctly.

Attachments (1)

6110-optionspage-oldchrome.jpg (72.3 KB) - added by Ross 2 years ago.

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by Ross

comment:1 Changed 2 years ago by Ross

I'm not sure if these errors are just test data related when running the test_server or would affect the page when displayed inside the extension.

Errors are:

Uncaught TypeError: elements[Symbol.iterator] is not a functionpolyfill.js:84

Uncaught TypeError: anchors[Symbol.iterator] is not a function desktop-options.js:1395

Uncaught (in promise) TypeError: elements[Symbol.iterator] is not a function(…) desktop-options.js:499

Uncaught TypeError: listItem.querySelectorAll(...)[Symbol.iterator] is not a function desktop-options.js:154

comment:2 follow-up: Changed 2 years ago by saroyanm

Ross, are you using webmate to test older Chrome browsers, or Virtual Machines ?

I used to have always issues with getting older Chrome versions installation on my device, after Google stopped to provide portable versions.

Will appreciate if you can help me, so I can test myself and update the ticket accordingly.

comment:3 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

Marking this ready as Dave started to work on it and already has provided link to the Chromium bug.

comment:5 Changed 2 years ago by greiner

  • Owner set to kzar

comment:6 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6110 - Add the iterator polyfills to the test page

comment:7 Changed 2 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 in reply to: ↑ 2 Changed 2 years ago by Ross

Replying to saroyanm:

Ross, are you using webmate to test older Chrome browsers, or Virtual Machines ?

I used to have always issues with getting older Chrome versions installation on my device, after Google stopped to provide portable versions.

Will appreciate if you can help me, so I can test myself and update the ticket accordingly.

I usually use the virtual machines that have most versions installed already. Philip should be able to hook you up with access to them.

comment:9 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

adblockplusui / 203:0e99fec067ea
Chrome 49 / 51 / Windows 7
Opera 39 / 40 / Windows 7

Last edited 2 years ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.