Opened 2 years ago

Last modified 22 months ago

#6113 closed defect

[webextension] Error when using block element in Firefox 50/51 — at Initial Version

Reported by: Ross Assignee:
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: trev, sebastian, kzar, greiner Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29632566/
https://codereview.adblockplus.org/29632569/

Description

Environment

ABP 3.0.1.1939
Firefox 50 / 51 / Windows 7

Does not occur on Firefox 52+.

How to reproduce

  1. Have the Firefox Console open.
  2. Navigate to a website (any).
  3. Select [ABP Icon] > [Block element] > Select any element.

Observed behaviour

Often a filter will not be suggested and if the user cancels the dialog, the highlight overlays/styles on the page are not removed. The following error also appears in the console:

TypeError: window.tabs is undefined adblockplus.js:2261:13

Expected behaviour

Block element dialog to be functional, highlights removed if canceled, error not to occur.

Change History (0)

Note: See TracTickets for help on using tickets.