Opened 2 years ago

Closed 2 years ago

Last modified 20 months ago

#6115 closed change (fixed)

Refactor icons

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone:
Module: User-Interface Keywords: options-page
Cc: greiner, ire Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29626565/
https://codereview.adblockplus.org/29636582/

Description

Background

Currently we do not have unified styles for icons that make them hardly maintainable, this leads to issues like repeating background which cause SVG render issues in some places (ex.: #6089 checkbox background-image repeat, though it's partially chrome SVG resize bug).

What to change

  • Unify SVG Icons styles
  • use .icon class to apply consistent styles to elements containing icons

Change History (10)

comment:1 Changed 2 years ago by saroyanm

  • Keywords options-page added
  • Owner set to saroyanm

comment:2 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6115 - Refactored icon classes

comment:4 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by saroyanm

  • Resolution fixed deleted
  • Status changed from closed to reopened

I just noticed a small issue, with the Acceptable Ads notificaiton close icon, I think that can be tackled as part of this issue still.

comment:6 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:7 Changed 2 years ago by abpbot

comment:8 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Icons display and function as expected after changes.

ABP 3.0.2.1968
Firefox 51 / 58 / 59 / Windows 7
Firefox Mobile 57 / Android 7.0.1

comment:10 Changed 20 months ago by Ross

Rechecked.

ABP 3.0.2.1983
Firefox Mobile 57 / Android 7.0.1
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 49 / Windows 7

Note: See TracTickets for help on using tickets.