Opened 22 months ago

Closed 3 weeks ago

#6119 closed defect (rejected)

[webextension] Use frameAncestors for whitelisting

Reported by: tschuster Assignee: tschuster
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: kzar, sebastian, greiner Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Legacy Adblock Plus for Firefox had this code https://hg.adblockplus.org/adblockplus/file/ee31d83e4fd7/lib/contentPolicy.js#l239 for whitelisting a request by looking at the whole parent chain of frames for that window. This is supported in Firefox 58 (currently beta) and up with the frameAncestors property. Implemented in huge parts by me in https://bugzilla.mozilla.org/show_bug.cgi?id=1305237. I am going to attach my patch for this very soon.

Change History (4)

comment:1 Changed 22 months ago by kzar

  • Cc kzar trev sebastian added
  • Component changed from Unknown to Platform
  • Milestone Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox deleted
  • Platform changed from Unknown / Cross platform to Firefox
  • Summary changed from Use frameAncestors for whitelisting to [webextension] Use frameAncestors for whitelisting

Please could you update the issue description to add more context about this and what needs to be changed + tested and how?

comment:2 Changed 21 months ago by fhd

  • Cc trev removed

comment:3 Changed 7 months ago by greiner

  • Cc greiner added

comment:4 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.