Opened 12 months ago

Closed 12 months ago

Last modified 11 months ago

#6139 closed defect (fixed)

Update buildtools dependency to revision d9e8c5035624

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: tlucas, sebastian, trev Blocked By: #5996
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29630090/

Description (last modified by kzar)

Background

We made some improvements #5996 to the release automation which would be nice to use for the upcoming 3.0.2 Firefox release. To do that we'll need to update the buildtools dependency.

Included changes in buildtools

The list of changes imported by this is:


What to change

Update the buildtools dependency to:

mercurial git
d9e8c5035624 0c8a9db

Adjust calls to buildtools.build.processArgs(BASE_DIR, sys.argv) to buildtools.build.process_args(BASE_DIR).

Update the example commands in the README since the -t platform argument must now come after the command name.

Hints for testers

Since there have been a bunch of changes to the build scripts here we should verify that the produced builds haven't changed inadvertently. I'll (Dave) do that.

Change History (7)

comment:1 Changed 12 months ago by kzar

  • Component changed from Unknown to Platform
  • Milestone set to Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox

comment:2 Changed 12 months ago by kzar

  • Description modified (diff)

comment:3 Changed 12 months ago by kzar

  • Description modified (diff)

comment:4 Changed 12 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 6139 - Update buildtools dependency to revision d9e8c5035624

comment:6 Changed 12 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 11 months ago by kzar

  • Verified working set

(I can't assign myself as the tester, but I have verified that the builds stayed the same with this change.)

Note: See TracTickets for help on using tickets.