Opened 2 weeks ago

Last modified 13 days ago

#6141 reviewing defect

Nightly build generation on the server is failing

Reported by: kzar Assignee: tlucas
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: tlucas, trev, ferris, sebastian, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29630555

Description (last modified by tlucas)

Environment

adblockpluschrome since 8f361c32c9c6.

How to reproduce

  1. Look at the server logs.

or:

  1. clone the current sitescripts master revision to a location of your choice
  2. create a temporary folder for nightly generation, e.g. /tmp/sitescriptsrun
  3. Create a custom signing key for Adblock Plus for Chrome as described here
  4. Create a file ~/sitescripts.ini with the following content:
    [DEFAULT]
    root=/tmp/sitescriptsrun
    hgroot=https://hg.adblockplus.org/
    mailer=/dev/null
    mailerDebug=no
    secret=somerandomstringhere
    
    [extensions]
    nightliesData=%(root)s/data/nightlies
    nightliesDirectory=%(root)s/www/devbuilds
    nightliesURL=https://adblockplus.org/devbuilds/
    nightlyIndexPage=extensions/template/nightlies.html
    changelogTemplate=extensions/template/changelog.html
    abpfirefox_repository=%(hgroot)s/adblockpluschrome/
    abpfirefox_type=gecko
    abpfirefox_name=Adblock Plus for Mozilla Firefox
    abpfirefox_downloadPage=/firefox
    abpfirefox_galleryID=adblock-plus
    abpchrome_repository=%(hgroot)s/adblockpluschrome
    abpchrome_type=chrome
    abpchrome_name=Adblock Plus for Chrome and Opera
    abpchrome_key=%(root)s/data/adblockpluschrome.pem
    
  1. Run the command cron would run to generate nightly builds (in your new sitescripts clone): $ python -m sitescripts.extensions.bin.createNightlies

Observed behaviour

usage: build.py [-h] [command] ...
build.py: error: argument [command]: invalid choice: 'chrome' (choose from
'build', 'devenv', 'setuptrans', 'translate', 'uploadtrans',
'gettranslations', 'docs', 'release', 'updatepsl')
ERROR:root:The build for abpchrome failed:
ERROR:root:Command '['/tmp/abpchromegst_Is/build.py', '-t', 'chrome',
'build', '-b', '1940', '-k', 'REDACTED',
u'/home/devbuilds/builds/adblockpluschrome/adblockpluschrome-3.0.1.1940.crx']'
returned non-zero exit status 2
Traceback (most recent call last):
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 716, in main
    build.run()
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 664, in run
    self.build()
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 353, in build
    subprocess.check_call(command, env=env)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/tmp/abpchromegst_Is/build.py', '-t',
'chrome', 'build', '-b', '1940', '-k',
'REDACTED',
u'/home/devbuilds/builds/adblockpluschrome/adblockpluschrome-3.0.1.1940.crx']'
returned non-zero exit status 2
usage: build.py [-h] [command] ...
build.py: error: argument [command]: invalid choice: 'gecko' (choose from
'build', 'devenv', 'setuptrans', 'translate', 'uploadtrans',
'gettranslations', 'docs', 'release', 'updatepsl')
ERROR:root:The build for abpfirefox failed:
ERROR:root:Command '['/tmp/abpfirefoxkif7rU/build.py', '-t', 'gecko',
'build', '-b', '1940beta',
u'/home/devbuilds/builds/adblockplusfirefox/adblockplusfirefox-3.0.1.1940beta.xpi']'
returned non-zero exit status 2
Traceback (most recent call last):
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 716, in main
    build.run()
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 664, in run
    self.build()
  File "/opt/sitescripts/sitescripts/extensions/bin/createNightlies.py",
line 353, in build
    subprocess.check_call(command, env=env)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/tmp/abpfirefoxkif7rU/build.py', '-t',
'gecko', 'build', '-b', '1940beta',
u'/home/devbuilds/builds/adblockplusfirefox/adblockplusfirefox-3.0.1.1940beta.xpi']'
returned non-zero exit status 2

Expected behaviour

No error.

Notes

This is probably a regression from #6139, we updated the buildtools dependency there and one of the changes included was that the processArgs function got renamed process_args (see #6021).

Change History (5)

comment:1 Changed 2 weeks ago by tlucas

  • Owner set to tlucas

comment:2 Changed 2 weeks ago by tlucas

  • Component changed from Unknown to Automation
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 2 weeks ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 weeks ago by tlucas

  • Priority changed from P2 to P1

comment:5 Changed 13 days ago by abpbot

A commit referencing this issue has landed:
Issue 6141, 6140 - Adapt to new build.py interface

Note: See TracTickets for help on using tickets.