Opened 13 days ago

Closed 4 days ago

Last modified 4 days ago

#6142 closed change (rejected)

Let ensure_dependencies.py respect -q while trying to install nodejs

Reported by: tlucas Assignee: tlucas
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: ferris, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Some of our servers currently have Node.js installed, some do not.
Those servers without Node.js installed currently spam monitoring with notifications about missing Node.js but other run their tasks as expected.

What to change

Let ensure_dependencies.py respect the -q parameter when trying to install Node.js dependencies. i.e. suppress the notification Failed to install Node.js dependencies for %s, please ensure Node.js is installed.

Change History (6)

comment:1 Changed 13 days ago by tlucas

  • Owner set to tlucas

comment:2 follow-up: Changed 13 days ago by sebastian

Perhaps a better approach would be to only run npm install if there is actually a packages.json. If there is none, there is no point in running npm install in the first place, but if there is one merely suppressing the error will just cause other issues down the road.

comment:3 in reply to: ↑ 2 Changed 13 days ago by kvas

Replying to sebastian:

Perhaps a better approach would be to only run npm install if there is actually a packages.json.

I think that's already working this way. However, we have a situation where we have a packages.json but failing to install those dependencies is not a problem on some (most) servers because they don't use the particular scripts that require Node.js.

comment:4 Changed 13 days ago by tlucas

comment:5 Changed 4 days ago by tlucas

  • Resolution set to rejected
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.