Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#6163 closed change (fixed)

Fix incorrect source strings in Options page project

Reported by: lisabielik Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, trev, Shikitita, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29631254/

Description

Background

For some reason, apostrophes were added to the English source strings:

We noticed you have both '<strong>$tracking$</strong>' and '<strong>$acceptableAds$</strong>' enabled.

AND

If you prefer extra privacy, select the '<strong>$acceptableAdsPrivacy$</strong>' checkbox below.

The apostrophes need to be removed, as it doesn't make sense to have things bolded and quoted.

What to change

Remove apostrophes ('/') from both strings:

We noticed you have both <strong>$tracking$</strong> and <strong>$acceptableAds$</strong> enabled.

If you prefer extra privacy, select the <strong>$acceptableAdsPrivacy$</strong> checkbox below.

Change History (7)

comment:1 Changed 22 months ago by saroyanm

  • Owner set to saroyanm
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 22 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 6163 - Fix incorrect source strings in Options page project

comment:4 Changed 22 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 22 months ago by trev

Before we give these strings to translators again, can we please make sure to make them proper first? Combining multiple strings into one the way this was done here is a huge footgun. In many languages, declination makes it impossible to insert the acceptableAds string without changes. Translators need to use tricks, e.g. in Russian I had to say "and the feature $acceptableAds$" to make it work. And I doubt that every translator even noticed the issue here.

comment:6 Changed 22 months ago by trev

Filed #6164 on this issue.

comment:7 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.1.1943
Firefox 51 / 57 / Windows 10

Note: See TracTickets for help on using tickets.