Opened 2 years ago

Closed 2 years ago

#6164 closed change (rejected)

Do not compose strings from parts

Reported by: trev Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: sebastian, Shikitita, saroyanm, lisabielik, greiner, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)

Background

We currently have the following translatable strings:

We noticed you have both <strong>$tracking$</strong> and <strong>$acceptableAds$</strong> enabled.

and

If you prefer extra privacy, select the <strong>$acceptableAdsPrivacy$</strong> checkbox below.

The placeholders are replaced by other strings here, which are also used on the page by itself. This causes issues for languages where nouns needs to be declined and requires translators to use tricks. For example, in Russian "and $acceptableAds$" had to be changed into "and the feature $acceptableAds$" to make sense grammatically. Not all translators will notice the issue, and not all will know how to deal with it.

What to change

Do not use placeholders, just insert the strings here:

We noticed you have both <strong>Block additional tracking</strong> and <strong>Allow Acceptable Ads</strong> enabled.

and

If you prefer extra privacy, select the <strong>Only allow ads without third-party tracking</strong> checkbox below.

This gives translators more flexibility and avoids grammatical mistakes.

Change History (12)

comment:1 Changed 2 years ago by trev

  • Description modified (diff)

comment:2 follow-up: Changed 2 years ago by saroyanm

  • Cc greiner added

Updating the Strings now will require re-adding the translations in the Crowdin, I have couple of questions to Tamara before fixing this issue:

  • Tamara, have you updated the Translation of this strings already (after #6163) ?
  • How much effort it will require you if I update the strings the way it's suggested here?
  • Do you agree that we shouldn't use placeholders ?

comment:3 Changed 2 years ago by saroyanm

  • Cc wspee added

comment:4 follow-up: Changed 2 years ago by trev

This is definitely not something to do before Adblock Plus 3.0.2 release - we have enough issues as it is already.

comment:5 in reply to: ↑ 4 Changed 2 years ago by saroyanm

Replying to trev:

This is definitely not something to do before Adblock Plus 3.0.2 release - we have enough issues as it is already.

Noted, I thought we want this before the release.

comment:6 follow-up: Changed 2 years ago by Ross

I'm guessing this issue and near-future translation updates would fix the acceptable ads notification appearing in multiple languages? Or should I create a new ticket for that?

Example when FF is set to DE:

We noticed you have both 'Blockieren von zusätzlichem Tracking' and 'Acceptable Ads erlauben?' enabled.

comment:7 Changed 2 years ago by greiner

@Shikitita Which one is easier to manage? Ensuring that the same texts are used across multiple strings or ensuring that translators handle placeholders properly?

comment:8 in reply to: ↑ 6 Changed 2 years ago by saroyanm

Replying to Ross:

I'm guessing this issue and near-future translation updates would fix the acceptable ads notification appearing in multiple languages? Or should I create a new ticket for that?

Example when FF is set to DE:

We noticed you have both 'Blockieren von zusätzlichem Tracking' and 'Acceptable Ads erlauben?' enabled.

Yes, the string is translated in the Crowdin, I'm just waiting for the Go(after all translations are ready) to import it to the ABPUI.

comment:9 in reply to: ↑ 2 ; follow-up: Changed 2 years ago by Shikitita

Replying to saroyanm:

Updating the Strings now will require re-adding the translations in the Crowdin, I have couple of questions to Tamara before fixing this issue:

  • Do you agree that we shouldn't use placeholders ?

Replying to greiner:

@Shikitita Which one is easier to manage? Ensuring that the same texts are used across multiple strings or ensuring that translators handle placeholders properly?

This should answer also saroyanm's question:

Obviously I'd rather ensure the translators handle placeholders properly, as it's less prone to error in the sense that we'd be using the right translations for those two sections. If we don't, we'd have to make sure these strings aren't updated by our community and risk the terms being inconsistent with the right wording for those two options.

comment:10 in reply to: ↑ 9 Changed 2 years ago by trev

Replying to Shikitita:

Obviously I'd rather ensure the translators handle placeholders properly,

How can you do that? Would you know that the sentence produced by replacing placeholders is grammatically incorrect?

comment:11 Changed 2 years ago by fhd

  • Cc trev removed

comment:12 Changed 2 years ago by greiner

  • Resolution set to rejected
  • Status changed from new to closed

Rejecting this ticket because we'd be replacing one issue with another one which is expected to be at least as difficult to deal with.

Note: See TracTickets for help on using tickets.