Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6169 closed change (fixed)

Update adblockplusui dependency to revision 0e99fec067ea

Reported by: saroyanm Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: trev, sebastian, Shikitita, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29631579
https://codereview.adblockplus.org/29631699/

Description (last modified by kzar)

Background

We've been working to improve the translations of the new Acceptable Ads and EasyPrivacy conflict message. We need to update the adblockplusui dependency of adblockpluschrome now in order to include those translations for the Adblock Plus 3.0.2 for Firefox release.

What to change

Update the adblockplusui dependency to hg:0e99fec067ea git:c4e39c7

Included changes in adblockplusui

The list of changes imported by this is:


Apart from the updated translations none of those changes are relevant, they are either to the build system (used for synchronising translations) or to the test page.

Hints for testers

Ensure the Acceptable Ads and privacy warning displays OK in different languages.

Change History (11)

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:2 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependencies to "rev" to Update adblockplusui dependencies to 0e99fec067ea

comment:3 Changed 2 years ago by saroyanm

  • Cc kzar sebastian added
  • Component changed from Unknown to Platform

comment:4 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:5 Changed 2 years ago by kzar

  • Cc trev Shikitita added; kzar removed
  • Description modified (diff)
  • Owner set to kzar
  • Priority changed from Unknown to P1
  • Ready set
  • Review URL(s) modified (diff)
  • Summary changed from Update adblockplusui dependencies to 0e99fec067ea to Update adblockplusui dependencies to revision 0e99fec067ea

comment:6 Changed 2 years ago by kzar

  • Description modified (diff)

comment:7 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Update adblockplusui dependencies to revision 0e99fec067ea to Update adblockplusui dependency to revision 0e99fec067ea

comment:8 Changed 2 years ago by abpbot

comment:9 Changed 2 years ago by kzar

  • Milestone set to Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 2 years ago by kzar

  • Cc Ross added

The release has been delayed until Tuesday the 12th, Ross any chance you could have a look at testing this issue before then?

comment:11 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. The acceptable ads message displays correctly in the languages I've tried (languages where the language pack has been updated for FF57).

ABP 3.0.1.1943
Firefox 52 / 57 / Windows 7

Note: See TracTickets for help on using tickets.