Opened 5 years ago

Last modified 4 years ago

#616 closed change

Disable generic hiding rules only + lessen the effect of $elemhide — at Initial Version

Reported by: Crits Assignee:
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Core Keywords: 2015q3
Cc: famlam, mapx, arthur, trev, manvel, greiner, sergz, ben Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/5840485868371968/
https://codereview.adblockplus.org/5991150368325632/
https://codereview.adblockplus.org/5138680696012800/
https://codereview.adblockplus.org/6439460933730304/
https://codereview.adblockplus.org/29325987/

Description

Based on this ABP forum topic : https://adblockplus.org/forum/viewtopic.php?f=4&t=19860

Lain wrote:

It's often needed on sites with adblock detection to be able to disable generic hiding rules since such sites often using them to detect presence of adblock or break functionality for adblock users. It's possible to disable them completely using 'elemhide' but this blocks usage of site-specific hiding rules and breaks ability to hide content in third-party frames.

So, I'd like to see something like ||site.name^$generichide which will disable only filters which is not assigned to any specific domain.

famlam wrote, about the current effect of $elemhide:

Unlike $document, which is used to whitelist whole sites (mostly by users, hardly by list authors) and therefore should also affect it's subframes, the purposes of $elemhide I could find in filter lists are to work around adblock detection scripts and to fix sites of ad related sites. However, such anti-adblock scripts are rarely active in the (third-party) subframes on those same pages. So if we could limit the effects of disabling all hiding rules to only first-party sub- and top frames, that would be a win.

Change History (0)

Note: See TracTickets for help on using tickets.