Changes between Initial Version and Version 3 of Ticket #6180


Ignore:
Timestamp:
03/13/2018 06:33:26 PM (2 years ago)
Author:
sergz
Comment:

It does not accomplish the issue, the added codereview merely allows String to be an UTF-8 string internally (it's even not complete because toLower is not properly implemented). So far it will be useful for #6452 - Use INI parser natively from emscripten branch of adblockpluscore.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6180

    • Property Cc rjeschke added; trev removed
    • Property Blocking changed from to 6452
  • Ticket #6180 – Description

    initial v3  
    99 
    1010=== What to change === 
    11 * Change the String classes to use UTF-8.  
     11* Change the String classes to use UTF-8 
     12 - pay attention to `String::toLower` and check that there is no deviations from it. 
    1213* Change everywhere else to use UTF-8.  
    1314* Change the bindings to convert where needed into JavaScript. The more C++ we use the less conversion will happen. 
  • Ticket #6180 – Review URL(s)

    initial v3  
     1https://codereview.adblockplus.org/29721753/