Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#6187 closed change (fixed)

Adjust query string parameters for Yandex

Reported by: mario Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29640558/

Description

Background

Yandex has recently started to support content blocking functionality in Yandex Browser for Android. They support all Samsung Internet content blockers out of the box and thus ABP for Samsung Internet is available within Yandex as well.
In order to differentiate between both, we'll need to adjust ABP for Samsung Internet's query string parameters while fetching filter lists.

What to change

  1. If ABP for Samsung Internet is used with Yandex, set the query string application to yandex
  2. If ABP for Samsung Internet is used with Samsung Internet, set the query string application to sbrowser
  3. If ABP for Samsung Internet is used with Yandex and Samsung Internet, set the query string application to sbrowseryandex

Change History (7)

comment:1 Changed 7 months ago by jwangenheim

  • Ready set

comment:2 Changed 7 months ago by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed 7 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 6187 - Adjust query string parameters for Yandex

comment:5 Changed 7 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 7 months ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:7 Changed 7 months ago by traynard

  • Verified working set

LGTM

Note: See TracTickets for help on using tickets.