Opened 4 months ago

Closed 4 months ago

#6194 closed change (fixed)

Kitt-Core: ABB does not build with TypeScript 2.6.x in Xcode 9.2

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Browser-for-iOS-next
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29638558/

Description (last modified by dzhang)

Background

A build error occurs in Xcode 9.2 when using TypeScript 2.6.x as installed by 'npm install'.

Here is a log of the reported errors:

src/JavaScriptBridge/TypeScriptInterface/main_content_mainframe.ts(69,13): error TS6133: 'html' is declared but its value is never read.
src/JavaScriptBridge/TypeScriptInterface/main_content_subframe.ts(40,15): error TS6133: 'html' is declared but its value is never read.

The TypeScript code may be able to be updated to work with the new TypeScript version but I'm uncertain of the impact any changes will have on the browser. Therefore, the conservative option is to limit the TypeScript version until these errors can be further evaluated. There is also a chance that the use of this TypeScript will be deprecated in favor of alternative options.

What to change

Limit the TypeScript version to 2.5.x instead of going to 2.6.x

Change History (6)

comment:1 Changed 4 months ago by dzhang

  • Description modified (diff)

comment:2 Changed 4 months ago by dzhang

  • Summary changed from ABB does not build with Typescript 2.6.x in Xcode 9.2 to Kitt-Core: ABB does not build with Typescript 2.6.x in Xcode 9.2

comment:3 Changed 4 months ago by dzhang

  • Review URL(s) modified (diff)

comment:4 Changed 4 months ago by dzhang

  • Status changed from new to reviewing

comment:5 Changed 4 months ago by dzhang

  • Description modified (diff)
  • Summary changed from Kitt-Core: ABB does not build with Typescript 2.6.x in Xcode 9.2 to Kitt-Core: ABB does not build with TypeScript 2.6.x in Xcode 9.2

comment:6 Changed 4 months ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.