Opened 12 months ago

Closed 12 months ago

Last modified 9 months ago

#6199 closed defect (fixed)

Acceptable Ads link broken on mobile options page

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords: goodfirstbug
Cc: wspee, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29639578/

Description

Environment

Nexus 5X
Android 8.1.0
Firefox 57
Adblock Plus 3.0.2

How to reproduce

  1. Open options page
  2. Click on "Learn more" link next to "Allow some non-intrusive advertising"

Observed behaviour

Options page is empty

Expected behaviour

New tab opens with information about Acceptable Ads

Further information

The options page is running within an iFrame so any link is, by default, opened within that frame. We acknowledged this issue when we decided to go for this workaround and checked links in the desktop options page but didn't notice that there'd be link on the mobile options page which are also affected by this.

Change History (5)

comment:1 Changed 12 months ago by greiner

  • Cc wspee saroyanm added
  • Owner set to greiner

comment:2 Changed 12 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 6199 - Fixed: Open link on mobile options page in new tab

comment:4 Changed 12 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 9 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.2.1983
Firefox 57 / Xperia Z / Android 5.1.1
Firefox 58 / Galaxy J5 / Android 7.1.1

Note: See TracTickets for help on using tickets.