Opened 3 years ago

Last modified 3 years ago

#6199 closed defect

Acceptable Ads link broken on mobile options page — at Version 2

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords: goodfirstbug
Cc: wspee, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29639578/

Description

Environment

Nexus 5X
Android 8.1.0
Firefox 57
Adblock Plus 3.0.2

How to reproduce

  1. Open options page
  2. Click on "Learn more" link next to "Allow some non-intrusive advertising"

Observed behaviour

Options page is empty

Expected behaviour

New tab opens with information about Acceptable Ads

Further information

The options page is running within an iFrame so any link is, by default, opened within that frame. We acknowledged this issue when we decided to go for this workaround and checked links in the desktop options page but didn't notice that there'd be link on the mobile options page which are also affected by this.

Change History (2)

comment:1 Changed 3 years ago by greiner

  • Cc wspee saroyanm added
  • Owner set to greiner

comment:2 Changed 3 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.