Changes between Initial Version and Version 1 of Ticket #6200, comment 1


Ignore:
Timestamp:
12/15/2017 10:47:25 AM (2 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6200, comment 1

    initial v1  
    55Note that we generally don't keep our own copy of build tools - not gcc, not CMake, and certainly not Visual Studio. gyp is a special case because we cannot really use it "as is." We have to wrap and monkey-patch it in order for gyp to become usable on Windows. And the vendor won't fix these issues (or anything, it has de facto already been unmaintained when we started using it). 
    66 
    7 Finally, I'm not convinced that installing ninja ourselves instead of letting the user do it is such a great idea. On Ubuntu, one will run `apt install ninja-build` and have that tool available globally for any tools that need it. Besides, are you certain that meson requires ninja to be added to `PATH`? From what I can tell, it's merely something for you to call ninja more conveniently - you could just as well invoke it with a full path instead. 
     7Finally, I'm not convinced that installing ninja ourselves instead of letting the user do it is such a great idea. On Ubuntu, one will run `apt install ninja-build` and have that tool available globally for any projects that need it. Besides, are you certain that meson requires ninja to be added to `PATH`? From what I can tell, it's merely something for you to call ninja more conveniently - you could just as well invoke it with a full path instead. 
    88 
    99Are you overthinking this maybe? What's the issue you are trying to solve? If this is about making it things easier for people working only on `adblockpluschrome` for example, then maybe committing `lib/compiled.js` to the repository is an easier solution than requiring people to build it themselves every time.