#6207 closed change (fixed)

Configure building directory

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29645586/

Description

Background

libadblockplus is building v8 and libadblockplus in "build" subdirectory by default and it's hardcoded in Makefile. Is seems to be not very flexible as GN requires all build files to be put in some specific directory (eg. out/%BuildTitle%/gen/%module%). Also i believe it's not good practise to mix the sources and build files so this configuration will not hurt definitely.

What to change

Add argument to configure build path or use "build" by default.

Change History (3)

comment:1 Changed 22 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 6207 - Add option to configure build output directory

comment:3 Changed 22 months ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.