Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#6208 closed defect (fixed)

Update adblockplusui dependency to revision f70786b535e3

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, saroyanm, greiner Blocked By: #6179, #6201
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29645603/

Description (last modified by kzar)

Background

We've fixed a problem which was preventing the "Hide targeted messages?" notifications from triggering (#6201) and we've also updated lots of translations for the new options page (#6179). Now we need to update the adblockplusui dependency to make use of those changes.

Included changes in adblockplusui

The list of changes imported by this is:


What to change

Update the adblockplusui dependency to:

mercurial git
f70786b535e3 8103830

Hints for testers

  • Test that the "Hide targeted messages?" notification is triggered for websites such as nexusmods.com.
  • With the new options page (desktop Firefox) ensure that
    • the strings are look OK, testing different languages
    • the interface to add and remove filters and subscriptions works
    • the buttons to toggle preferences and AA work
    • the social media buttons work
    • the AA with privacy conflict message works, including the button to hide it

Change History (5)

comment:1 Changed 2 years ago by kzar

  • Description modified (diff)

comment:2 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

comment:4 Changed 2 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Strings are updated and generally look okay, some languages have some minor alignment/padding issues (such as in the cog dropdowns) but functionality is fine. Privacy conflict message works as expected.

ABP 3.0.2.1983
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 49 / Windows 7

Note: See TracTickets for help on using tickets.