Opened 2 years ago

Closed 21 months ago

Last modified 20 months ago

#6209 closed defect (fixed)

Different font is used in some translations and Filter Lists table status column missalignment

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Shikitita, jeen, ire, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29654555/

Description (last modified by saroyanm)

Environment

Chrome V63

How to reproduce

  1. Download ​adblockplusui repository and run the test server
  2. Navigate to -> http://127.0.0.1:5000/desktop-options.html?locale=ru#advanced
  3. Observe

Observed behaviour

  • Font weight looks completely different from the default en_US one especially headers are noticeable (Though in FF they look different)
  • Filter List Status column text next to toggle button breaks to the next libe

Screenshot attachments: Firefox v57, Chrome v63

Expected behaviour

  • Font weight are same as in the en_US
  • Status column text fits while can, but when it breaks there shouldn't be a left margin.

Attachments (2)

FF-font-weight.png (106.2 KB) - added by saroyanm 2 years ago.
chrome-font-weight.png (128.5 KB) - added by saroyanm 2 years ago.

Download all attachments as: .zip

Change History (12)

Changed 2 years ago by saroyanm

Changed 2 years ago by saroyanm

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:2 Changed 2 years ago by saroyanm

  • Summary changed from Filter list status column text next to the toggle button breaks to next line to Font weight difference in translations and Filter Lists table status column missalignment

comment:3 Changed 2 years ago by saroyanm

  • Cc Ross added

comment:4 Changed 23 months ago by saroyanm

  • Owner set to saroyanm

comment:5 Changed 23 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 23 months ago by saroyanm

  • Summary changed from Font weight difference in translations and Filter Lists table status column missalignment to Different font is used in some translations and Filter Lists table status column missalignment

comment:8 Changed 21 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 21 months ago by saroyanm

I've created a followup ticket to fix/investigate what can we do with the missing Source Sans Pro support for some languages

comment:10 Changed 20 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed for Russian and Vietnamese. This still occurs with Greek (opened as #6530)

ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.