Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#6210 closed change (rejected)

Implement ABP newsletter signup form

Reported by: ire Assignee:
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: jeen, juliandoucette, wspee, jnink Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Code Review - https://codereview.adblockplus.org/29646555/
Backclick Preview - https://eyeomail.com/bc/servlet/web.subscribe?tid=14&mid=0

Description (last modified by saroyanm)

Implement ABP newsletter signup form in accordance with the Specification

Link to the English version of Backclick documentation can be found here.

Attachments (3)

Screen Shot 2017-12-21 at 1.44.17 pm.png (301.2 KB) - added by ire 2 years ago.
Default Confirmation Email
email template.jpg (45.3 KB) - added by jeen 2 years ago.
email template - style.jpg (137.2 KB) - added by jeen 2 years ago.

Download all attachments as: .zip

Change History (33)

comment:1 Changed 2 years ago by ire

  • Cc jnink added; judith removed

comment:2 Changed 2 years ago by ire

  • Owner set to ire

comment:3 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed 2 years ago by ire

Default Confirmation Email

comment:4 Changed 2 years ago by ire

@all : It looks like we will also have to create a new confirmation email template. When the user signs up, they receive an email telling them to confirm that they want to subscribe. I've attached a screenshot of what this currently looks like.

As you can see, it looks pretty bad :( I don't think we should launch this new newsletter signup page without also fixing this as well.

comment:5 Changed 2 years ago by jeen

Thanks for bringing this to our attention. Agreed, we should not launch without an email template. Marsha and I are working on this now, and will add it to the issue on GitLab, but this shouldn't block you for now.

Changed 2 years ago by jeen

Changed 2 years ago by jeen

comment:6 follow-up: Changed 2 years ago by jeen

Hi Ire,

I have attached the email template designs, let me know if these work?

comment:7 in reply to: ↑ 6 Changed 2 years ago by ire

Replying to jeen:

Hi Ire,

I have attached the email template designs, let me know if these work?

Thanks Jeen! This looks good to me. I'm going to create a separate issue for the email template so any discussion on that can happen there.

comment:8 Changed 2 years ago by ire

@all: Issue #6215 - Create custom email template for ABP Newsletter

comment:9 Changed 2 years ago by ire

  • Review URL(s) modified (diff)

comment:10 follow-up: Changed 2 years ago by ire

In codereview, On 2017/12/21 16:07:57, saroyanm wrote:

I assume we are planing to update the privacy policy to reflect the backclick
privacy policy and link to that header, right ?
Also, make sense to check to which website the update will land, because we also
used to have extended Privacy Policy in http://eyeo.com, with Privacy Policy
information like "talent tracker".

@wspee @jeen Could you help answer this?

comment:11 Changed 2 years ago by jeen

Yes we will be adding it to the eyeo.com privacy policy as per the ticket on [GitLab here](https://gitlab.com/eyeo/web.eyeo.com/issues/2)

comment:12 in reply to: ↑ 10 Changed 2 years ago by wspee

Replying to ire:

In codereview, On 2017/12/21 16:07:57, saroyanm wrote:

I assume we are planing to update the privacy policy to reflect the backclick
privacy policy and link to that header, right ?
Also, make sense to check to which website the update will land, because we also
used to have extended Privacy Policy in http://eyeo.com, with Privacy Policy
information like "talent tracker".

@wspee @jeen Could you help answer this?

To not have to go through translations (this would add ~1-2 Month currently) we decided to add the backclick related changes the eyeo.com privacy policy (the form is not part of abp.org) instead, see:

https://gitlab.com/eyeo/web.adblockplus.org/issues/1#what-to-do
https://gitlab.com/eyeo/web.eyeo.com/issues/2

The newsletter sign up form links to the eyeo.com privacy policy see:

https://gitlab.com/eyeo/spec/merge_requests/110/diffs#14aa898ad23db081e78a168a4f41e7aad0e7c32c_0_70

Both changes (in conjunction) have been LGTMed by Judith.

comment:13 Changed 2 years ago by ire

Thanks @Jeen and @Wspee . So I will link to https://eyeo.com/en/privacy from the signup form instead

comment:14 Changed 2 years ago by jeen

@ire correct!

comment:15 follow-up: Changed 2 years ago by saroyanm

I'm not sure why we have chosen Backclick, but I'll strongly discourage to consider any service provider in future(with hope that we will find alternative to current one) who doesn't provide documentation and support in English, even comments in the code are in German, that's a dangerous practice.

comment:16 in reply to: ↑ 15 Changed 2 years ago by saroyanm

Replying to saroyanm:

I'm not sure why we have chosen Backclick, but I'll strongly discourage to consider any service provider in future(with hope that we will find alternative to current one) who doesn't provide documentation and support in English, even comments in the code are in German, that's a dangerous practice.

Never-mind, I saw in the IRC channel that they have English documentation, but non of our Developers were aware of it's existence.

comment:17 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:18 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:19 follow-up: Changed 23 months ago by ire

@wspee: Backclick has a feature to create a blacklist of emails we don't want to be allowed to subscribe to the newsletter. Would you like us to support it in our template?

For context, this feature is currently supported in our template and doesn't require much more/any development effort to include it. But, if we won't use it we should remove it from the template for less clutter.

comment:20 Changed 23 months ago by juliandoucette

P2 because comms would like to send a newsletter next week.

Last edited 23 months ago by juliandoucette (previous) (diff)

comment:21 in reply to: ↑ 19 ; follow-up: Changed 23 months ago by wspee

Replying to ire:

@wspee: Backclick has a feature to create a blacklist of emails we don't want to be allowed to subscribe to the newsletter. Would you like us to support it in our template?

For context, this feature is currently supported in our template and doesn't require much more/any development effort to include it. But, if we won't use it we should remove it from the template for less clutter.

What blacklist? Are you talking about the eRobinson feature?
https://www.backclick.de/confluence/display/BC5EN/Basics+on+eRobinson+lists

comment:22 in reply to: ↑ 21 ; follow-up: Changed 23 months ago by ire

Replying to wspee:

Replying to ire:

@wspee: Backclick has a feature to create a blacklist of emails we don't want to be allowed to subscribe to the newsletter. Would you like us to support it in our template?

For context, this feature is currently supported in our template and doesn't require much more/any development effort to include it. But, if we won't use it we should remove it from the template for less clutter.

What blacklist? Are you talking about the eRobinson feature?
https://www.backclick.de/confluence/display/BC5EN/Basics+on+eRobinson+lists

Yes I'm referring to the eRobinson feature

comment:23 in reply to: ↑ 22 ; follow-up: Changed 23 months ago by wspee

Replying to ire:

Yes I'm referring to the eRobinson feature

Hmm normally this is used to exclude receivers that would hurt the delivery of the newsletter, not sure why a user would want to use it?!

Is it perhaps a backclick quirk and normally used to handle opt-outs? If not I would say remove it? @Jeen?

https://docs.aws.amazon.com/ses/latest/DeveloperGuide/e-faq.html#e-faq-bn

comment:24 in reply to: ↑ 23 ; follow-up: Changed 23 months ago by ire

Replying to wspee:

Replying to ire:

Yes I'm referring to the eRobinson feature

Hmm normally this is used to exclude receivers that would hurt the delivery of the newsletter, not sure why a user would want to use it?!

My question was to ask if *we* want to support it.

If we are planning on using it, we would need to have something on the frontend to let the user know that the reason they cannot sign up with the particular email address is because it is part of this blacklist/eRobinson list.

If we are not planning on using it, we would remove this logic from the template.

comment:25 in reply to: ↑ 24 ; follow-up: Changed 23 months ago by jeen

I would say we don't need to support this, so let's remove the logic from the template.

Replying to ire:

Replying to wspee:

Replying to ire:

Yes I'm referring to the eRobinson feature

Hmm normally this is used to exclude receivers that would hurt the delivery of the newsletter, not sure why a user would want to use it?!

My question was to ask if *we* want to support it.

If we are planning on using it, we would need to have something on the frontend to let the user know that the reason they cannot sign up with the particular email address is because it is part of this blacklist/eRobinson list.

If we are not planning on using it, we would remove this logic from the template.

comment:26 in reply to: ↑ 25 Changed 23 months ago by ire

Replying to jeen:

I would say we don't need to support this, so let's remove the logic from the template.

Alright. Thanks!

comment:27 Changed 22 months ago by juliandoucette

  • Ready unset

comment:28 Changed 22 months ago by ire

  • Resolution set to rejected
  • Status changed from reviewing to closed

comment:29 Changed 22 months ago by ire

  • Owner ire deleted
Note: See TracTickets for help on using tickets.