Opened 2 years ago

Closed 15 months ago

#6216 closed defect (fixed)

Python-abp does not parse abp-properties filters as expected

Reported by: Kirill Assignee: atudor
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Kirill, kvas Blocked By: #6835
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

I would expect

boerse-online.de#?#:-abp-properties(/margin-left: 1[0-9][0-9]{2}px;/)

to parse boerse-online.de as domain and the rest as selector.value.
This does not happen.

Change History (5)

comment:1 Changed 2 years ago by Kirill

Another example

hardwareluxx.de,tiervermittlung.de,landwirt.com,finanzen.net,tvtoday.de#?#:-abp-properties(/margin-left: 1[0-9][0-9]{2}px;/)

comment:2 Changed 16 months ago by atudor

  • Owner set to atudor

comment:3 Changed 16 months ago by atudor

After further investigation, it looks like the new version of python-abp (https://github.com/adblockplus/python-abp) supports this kind of syntax and returns the expected results.

Therefore, after the R integration will be done (see ticket here: https://issues.adblockplus.org/ticket/6835), this ticket can be automatically close, as the new version supports this filter format.

comment:4 Changed 16 months ago by atudor

  • Blocked By 6835 added

comment:5 Changed 15 months ago by atudor

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.