Opened 2 years ago

Last modified 2 years ago

#6217 closed change

Correct behavior of whitelisting a domain — at Version 1

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29647688/

Description

Background

It has been observed that the time it takes for whitelisting to take effect is inconsistent.

This has been traced to an implementation error where the content blocker was incorrectly being reloaded at the wrong time.

It appears that calling reload on the content blocker more than once concurrently can cause unexpected effects such as a crash during content blocker access or code execution being halted.

Removing extraneous content blocker reload calls appears to greatly improve the consistency of whitelisting by causing the whitelisted site to be recognized almost immediately after whitelisting.

A future improvement can involve a notification to let the user know that when the whitelisting has been completed.

What to change

Prevent extraneous reloads of the content blocker so that the reloads do not interefere with whitelisting operations.

Change History (1)

comment:1 Changed 2 years ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.