Opened 2 years ago

Last modified 7 months ago

#6220 closed change

add CI for adblockpluscore — at Version 4

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: kzar, hfiguiere, tlucas, mjethani, erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29663680/
https://codereview.adblockplus.org/29663688/
https://codereview.adblockplus.org/29714583/
https://codereview.adblockplus.org/29716557/
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/1
https://codereview.adblockplus.org/29875559/

Description

Background

It will help a lot if we have CI for the core, mainly because we want to be sure that not only JS part but also the code which is used in native applications on different platforms (e.g. in libadblockplus-andoid) is at least compilable.

I propose to have a configuration for travis-ci (host-platforms: {linux, osx}, target-platfoms: {linux, osx, android}), for appveyor (windows) and optionally for circle-ci because we have a mirror on github which is easily integrable with the services, these services seem the most popular ones and everyone, who is willing to contribute, can easily and for free use them before sending a codereview/pull request.

What to change

  • create corresponding configurations for master branch (JS tests only)
  • based on the config for master branch create a config for emscripten. Details will come later because it can require additional investigations regarding preparation of emscripten and meson.

Additional notes

This approach is already in a working form #5133 for libadblockplus.

Change History (4)

comment:1 Changed 2 years ago by kzar

I know Tristan is already playing with using GitLab for CI, so I think we should see what he thinks. Also I suspect this issue might come under the buildtools module. Either way I'd love to see more CI as well.

comment:2 Changed 2 years ago by tlucas

I am investigating CI with gitlab, yes - but i'm also evaluating travis-ci. No strong preference yet here.

comment:3 Changed 2 years ago by kzar

Awesome OK, well when you've got a better idea how our CI system will be setup let us know what changes we'll need to make to the adblockpluscore repository and we can update this issue.

comment:4 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

I have added two codereviews (so far only osx and linux) FYI. The first one is ready and working. The second one is not working right now because precompiled emscripten is linked with libraries which are incompatible with ones currently available by default on travis servers. Compiling of emscripten each time on the server is not an option, therefore I guess we will have to prepare and host a compatible version (BTW we do it already for v8 in libadblockplus). However, the rest should be correct. In addition, I have not tested the one for emscripten on osx because travis-ci is experiencing big troubles with osx machines right now.

Note: See TracTickets for help on using tickets.