#6229 closed change (fixed)

Add support for RxSwift and FavIcon libraries in build.py script

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29656622/

Description (last modified by dzhang)

Background

The RxSwift library was added to the Swift version of ABP. The FavIcon library was also added to provide favicons for use with the Safari action extension.

Both libraries have been added as frameworks managed by Carthage.

What to change

Update build.py to support RxSwift and the FavIcon library.

Change History (6)

comment:1 Changed 22 months ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by dzhang

  • Review URL(s) modified (diff)

comment:3 Changed 22 months ago by dzhang

  • Status changed from reviewing to reopened

comment:4 Changed 22 months ago by dzhang

  • Description modified (diff)
  • Summary changed from Add support for FavIcon library in build.py script to Add support for RxSwift and FavIcon libraries in build.py script

comment:5 Changed 22 months ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:6 Changed 22 months ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.