Opened 18 months ago

Closed 11 months ago

Last modified 11 months ago

#6238 closed change (fixed)

Download/store notifications.json

Reported by: mario Assignee:
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.6
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: #3725 Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29760569/

Description

Background

As preparation for #3725 and as an option for us to properly assess volume of use, we'd like to adopt the functionality to fetch and store the notifications.json before #3725 – which is more complicated and time consuming – is implemented.

What to change

Regularly fetch and store notifications.
Technical implementation TBD.

References

Notifications have been implemented in other extensions already. The changes can be found here:

Change History (6)

comment:1 Changed 14 months ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Priority changed from Unknown to P2
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 14 months ago by mario

  • Milestone changed from Adblock-Plus-for-Samsung-Browser-1.1.5 to Adblock-Browser-for-Android-next

comment:3 Changed 13 months ago by diegocarloslima

  • Milestone changed from Adblock-Browser-for-Android-next to Adblock-Plus-for-Samsung-Browser-next

comment:4 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 6238 - Download/store notifications.json

comment:5 Changed 11 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 11 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.