Opened 2 years ago

Closed 22 months ago

#6244 closed defect (fixed)

FavIcon: Tests to be fixed

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: #6245, #6262 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29664565/

Description

The tests in the FavIcon library are currently not working due to a change in logic in the FavIcon.swift class
Both the tests class and the FavIcon.swift class need to be updated in order to repair the failing tests.

Change History (4)

comment:1 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by ashephard

  • Blocking 6245 added

comment:3 Changed 23 months ago by dzhang

  • Blocking 6262 added

comment:4 Changed 22 months ago by ashephard

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.