Opened 3 years ago

Last modified 12 months ago

#6254 new change

Fix potential race conditions

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



We should take care about concurrency. Let's say in background threads (see we check for filterEnginePtr to be not null. If it's not we continue working with it. But it can be released actually but setting null from java side to c++ not yet sent/received:

FilterEngine is mostly accessed from background but creating/releasing happens in main thread.

What to change

We need to change the way "don't use it anymore" notifications is sent or prevent filter engine from actual disposing until it not needed anymore.

Change History (2)

comment:1 Changed 15 months ago by elimitix


Last edited 12 months ago by kzar (previous) (diff)

comment:2 Changed 14 months ago by slotxo777


Last edited 12 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.