Opened 14 months ago

Last modified 9 months ago

#6255 new change

Use full request frame tree

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We're using only last request referrer as known frame parent:
https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/net/chrome_network_delegate.cc#L381

However for proper adblocking we'd better use full frame tree, flattened and passed as documentUrls:
https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/net/chrome_network_delegate.cc#L429

What to change

Use full request frame tree

Change History (6)

comment:1 Changed 10 months ago by asmirnov

  • Priority changed from P2 to P3

comment:2 Changed 10 months ago by asmirnov

It looks like we can't get RenderFrameHost instance ptr instantly, we have to use callback that should be called on UI thread:
https://gitlab.com/eyeo/adblockplus/chromium/blob/dev-65.0.3325.181_2/content/public/browser/resource_request_info.h#L94

Since we try to access it from chrome_network_delegate.cc it seems to be problematic: we will have to wait until we get response in UI thread and return back here (so it will lock this background thread and increase loading time significantly). A user can also do smth in UI thread (like scrolling) so it looks even more problematic.

comment:5 Changed 10 months ago by asmirnov

Note: See TracTickets for help on using tickets.