Opened 22 months ago

Last modified 22 months ago

#6258 new change

Refactor usage of global variables

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

In order to make java/c++ interaction easier i had to use global variables (AdblockBridge::filterEnginePtr and below):
https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/android/adblock/adblock_bridge.cc#L278

That worked great for simplicity and making proof-of-concept but i don't like it. I'd prefer better solution.

What to change

Refactor a bit - move global variables to some class members.

Change History (1)

comment:1 Changed 22 months ago by asmirnov

  • Summary changed from Refactor using global variables to Refactor usage of global variables
Note: See TracTickets for help on using tickets.