Opened 22 months ago

Last modified 5 weeks ago

#6259 new change

Find more suitable event for element hiding

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

While implementing element hiding (https://gitlab.com/adblockplus/chromium/commit/04b8bb8ba55ce187a68f12b4e7280440281fbc78) i had to introduce new event NOTIFICATION_DID_FINISH_NAVIGATION.

However i believe we could find more suitable event when the DOM is created but not yet rendered to avoid flickering (in some cases i still can see that empty block is shown and then JS injected and empty block is hidden).

What to change

Find more suitable event for element hiding and use it

Change History (1)

comment:1 Changed 5 months ago by pappyvicky

spam

Last edited 5 weeks ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.