Changes between Version 2 and Version 3 of Ticket #6262


Ignore:
Timestamp:
01/14/2018 01:41:41 AM (2 years ago)
Author:
dzhang
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6262 – Description

    v2 v3  
    11=== Background === 
    2 A few problems were found with the addition of the FavIcon library version 2.0.1. 
     2A few problems were found with the addition of the FavIcon library version 2.0.1 when tested on both a simulator and a device running iOS 11.2.x. 
    33 
    44* FavIcon library is not in Embedded Binaries - The app crashes upon accessing the Action Extension 
     
    4242=== What to change === 
    4343* Add the FavIcon library to the Embedded Binaries for the AdblockPlusSafari target. 
    44 * Move FavIcon.framework to Frameworks group 
    45 * Deleted Recovered Frameworks group 
    46 * Prevent crashing in chooseIcon in FavIcon library. There are many instances of forced unwrapping in that function. 
     44* Move FavIcon.framework to group `Frameworks` and delete the  `Recovered Frameworks` group 
     45* Prevent crashing in `chooseIcon` in the FavIcon library. There are many instances of forced unwrapping in that function.