Opened 3 years ago

Closed 13 months ago

#6266 closed change (rejected)

[emscripten] Add tests for case lowering functionality

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Changing the case of characters can be a tricky operation, therefore we should ensure that

  • it works not only for ASCII
  • it does not depend on a global locale (in particular when it's compiled with Visual C++ or for android)
  • the behavior of some edge cases can deviate from the standard but it should be expected (check that there are no such cases in commonly used subscriptions)
  • there is no undefined behavior

What to change

Add the corresponding tests, preferably testing the same cases in JS and in native versions.

Change History (2)

comment:1 Changed 3 years ago by sergz

  • Summary changed from Add tests for case lowering functionality to [emscripten] Add tests for case lowering functionality

comment:2 Changed 13 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.