#6277 closed change (fixed)

Subproc.py should wait for subprocess to finish

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29670584/

Description

Background

Subproc.py is used in libadblockplus and libadblockplus-android to start subprocess to build with external build tool. At the moment it does not wait for process to finish allowing do it concurrently. But this leads to incorrect subprocess returncode returned (always 0).

What to change

Modify subprocess.py to wait for subprocess to finish.

Change History (2)

comment:1 Changed 23 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 23 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.