Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#628 closed defect (fixed)

Change look of overflow mechanism on acceptableads.org

Reported by: ben Assignee: greiner
Priority: P3 Milestone:
Module: Websites Keywords: manifesto
Cc: greiner, sven, fhd Blocked By: #1016
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5137220793008128/

Description (last modified by greiner)

Background

We wanted to be able to list more signatories than we had when we initially launched the page. For this purpose we added an overflow mechanism (see #545) but because of the wording and where it is placed on the page, its purpose is somewhat nebulous.
Therefore we want to improve on the design and show more organizations by default.

What to change

At https://acceptableads.org

  • Remove overflow section (element with ID supporters-overflow)
  • Append signatories currently listed under "show all" with icons (see #1016), to the existing list (element with ID supporters)

Change History (16)

comment:1 Changed 6 years ago by philll

Please describe in more detail, what "(Maybe) adding an icon" means, and which icon (attach it) shall be used for what and where exactly.

comment:2 Changed 6 years ago by greiner

Currently, when you click on "show all" it turns into "hide all". What should "Complete list of supporters" say after clicking on it?

comment:3 follow-up: Changed 6 years ago by sven

We could say "Show complete list of supporters \/" and after clicking "Hide complete list of supporters /\". What do you think @ben, @greiner

comment:4 in reply to: ↑ 3 Changed 6 years ago by ben

  • Description modified (diff)

Description changed.

comment:5 Changed 5 years ago by philll

  • Component changed from Unknown to Infrastructure
  • Platform set to Unknown

Please decide on whether this shall actually be done and get the description contain all details to either get this set "ready" or closed as wontfix/invalid.

comment:6 Changed 5 years ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:7 Changed 5 years ago by ben

We could say "Show complete list of supporters \/" and after clicking "Hide complete list of supporters /\". What do you think @ben, @greiner

Looks good to me.

comment:8 Changed 5 years ago by philll

  • Ready unset

You are obviously still discussing details here, so the issue by nature cannot be ready. Once you are finished, please creat a clear and clean description with a decent background and a greatly detailed what to change section as shown in new change issue templates.

comment:9 Changed 5 years ago by greiner

  • Description modified (diff)
  • Ready set

This has been discussed already but it just wasn't set to ready.

I updated the description with more background information on this issue and clarified what needs to be done.

comment:10 Changed 5 years ago by philll

  • Description modified (diff)
  • Ready unset

please clarify, what an overflow section is. Which icons shall be used for the ones not having one yet?

comment:11 Changed 5 years ago by greiner

  • Blocked By 1016 added

comment:12 Changed 5 years ago by greiner

  • Description modified (diff)

comment:13 Changed 5 years ago by greiner

  • Owner set to greiner

comment:14 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:15 Changed 5 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:16 Changed 5 years ago by trev

  • Component changed from Infrastructure to Websites
Note: See TracTickets for help on using tickets.