Opened 16 months ago

Last modified 16 months ago

#6287 reviewing change

Create codename Orca v.0 to launch internally to the team

Reported by: tpregueiro Assignee: jwangenheim
Priority: P2 Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: jwangenheim, diegocarloslima, asmirnov, mvelchevski, mario, greiner Blocked By: #6273
Blocking: Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29684695/

Description (last modified by jwangenheim)

Background

We already have a working version of adblockplus working on top of chromium for Android. We would like to start distributing a version of it to the team internally, to get their first impressions.

What to change

  • Create a build with existing code (chromium+ABP)
  • Change the icon
  • Change the name of the App to Orca
  • Change the namespace to avoid conflict with other chromium based browsers people may have on their phones
  • Add a basic versioning

Attachments (4)

Orca - Assets.zip (493.5 KB) - added by martin 16 months ago.
Archive containing assets needed to kickstart the development process
Orca - Assets (2).zip (348.3 KB) - added by martin 16 months ago.
Shortcut icon.zip (51.0 KB) - added by jwangenheim 16 months ago.
Fixed shortcut icons
Shortcut icon.2.zip (51.6 KB) - added by jwangenheim 16 months ago.
One more time, fixed shortcut icons

Download all attachments as: .zip

Change History (23)

Changed 16 months ago by martin

Archive containing assets needed to kickstart the development process

comment:1 Changed 16 months ago by martin

I updated this ticket with all assets needed to begin working on the project. Let me know if anything is missing or broken.

comment:2 Changed 16 months ago by tpregueiro

  • Cc jwangenheim diegocarloslima asmirnov mvelchevski mario added

comment:3 Changed 16 months ago by mario

We'll also need a ticket to create a repository. @Jens, Diego, Anton, would you like to work with Mercurial or GitLab?

comment:4 Changed 16 months ago by jwangenheim

Gitlab is fine for me

comment:5 Changed 16 months ago by diegocarloslima

Gitlab is fine for me too

comment:6 Changed 16 months ago by asmirnov

Gitlab for sure

comment:7 Changed 16 months ago by mario

An internal issue for creating the Repo has been created: #7382 on Hub.
You should get invitations soon.

comment:8 Changed 16 months ago by jwangenheim

Should we add a distribution tool in a separate ticket (HockeyApp or something similar)?

comment:9 Changed 16 months ago by asmirnov

  • Blocked By 6273 added

comment:10 Changed 16 months ago by asmirnov

We will have to merge the changes for #6263 (and #6273 is logical continuation of the issue) to new repository (for Orca) i've added #6273 as blocking ticket.

comment:11 Changed 16 months ago by asmirnov

@martin, new icon sizes required.

See icon dimensions in https://gitlab.com/adblockplus/chromium/tree/master/chrome/android/java/res_chromium/drawable- ...
Also it would be great to have 'product_logo_name' files: https://gitlab.com/adblockplus/chromium/blob/master/chrome/android/java/res_chromium/drawable-hdpi/product_logo_name.png
(see other dirs) too.

Could you prepare other files to be overriden, e.g https://gitlab.com/adblockplus/chromium/tree/master/chrome/android/java/res_chromium/mipmap-hdpi/app_shortcut_icon.png and app_single_page_icon.png.

BTW please check you have transparency in .png (it seems it's just white background instead at the moment).

comment:12 Changed 16 months ago by tpregueiro

  • Description modified (diff)

For the time being, and after discussion with the team we agreed to ditch the requirement to add a splash screen. Updating the ticket description

Changed 16 months ago by martin

comment:14 Changed 16 months ago by martin

@asmirnov I included a new archive containing the missing assets. Let me know if anything needs fixing.

comment:15 Changed 16 months ago by asmirnov

I believe we should not just hardcode "Orca" string to the files, but update them while building.
See https://github.com/Jubata/Cheetah-browser/wiki

Changed 16 months ago by jwangenheim

Fixed shortcut icons

Changed 16 months ago by jwangenheim

One more time, fixed shortcut icons

comment:16 Changed 16 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 Changed 16 months ago by jwangenheim

  • Owner set to jwangenheim

comment:18 Changed 16 months ago by jwangenheim

  • Description modified (diff)

comment:19 Changed 16 months ago by greiner

  • Cc greiner added
Note: See TracTickets for help on using tickets.