#6303 closed change (fixed)

Introduce basic foundation for automation in adblockplusui

Reported by: greiner Assignee: agiammarchi
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, wspee, agiammarchi Blocked By: #6288
Blocking: #6117 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29677659/

Description

Background

We've agreed on using various tools to establish a more coherent experience throughout front-end projects. For now this means that we want to use Node, gulp, ESLint and Stylelint to establish some basic automation in adblockplusui, with more to follow later on.

For translations, it's not yet clear how we want to integrate buildtools into it though so we should probably keep it unchanged for now.

What to change

  • Introduce package.json and define scripts for
    • Running linters
    • Starting test server (for now we can simply call test-server.py)
    • Resolving buildtools dependency using the "prepare" name (for now we can simply call ensure-dependencies.py)
  • Add development dependencies for linters so that we can resolve these dependencies automatically by running npm install
  • Due to negative experiences, we should avoid including package-lock.json at this point (see #5856).
  • Update README.md to reflect changes

Change History (8)

comment:1 Changed 22 months ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

We've agreed on the proposed approach on IRC so marking it as "ready".

comment:2 Changed 22 months ago by agiammarchi

  • Owner set to agiammarchi

comment:3 Changed 22 months ago by agiammarchi

  • Blocked By 6288 added

comment:4 Changed 22 months ago by saroyanm

  • Blocking 6117 added

comment:5 Changed 22 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 22 months ago by abpbot

comment:7 Changed 20 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

adblockplusui / 236:9546f62e182f

comment:8 Changed 19 months ago by agiammarchi

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.