Opened 2 years ago

Closed 5 months ago

#6304 closed change (rejected)

Find an alternative to :scope for relative Element hiding emulation filters

Reported by: hfiguiere Assignee:
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: mjethani, kzar, sergz, oleksandr Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)

Background

In order for relative selectors to work properly when combined with our special pseudo classes such as :abp-has we sometimes need to prefix selectors with the ​:scope CSS pseudo class (see #5436).

Unfortunately :scope is not yet supported by Microsoft Edge and therefore filters which use it are ignored.

What to change

  • Detect if :scope isn't available (querySelector() will throw an exception).
  • Switch to alternative method to build the selector if :scope isn't available, likely slower.
  • Ensure to run the test with both code path.

Notes

Change History (6)

comment:1 Changed 2 years ago by kzar

  • Cc sergz oleksandr added
  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Edge
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Find an alternative to :scope in Element hiding emulation to Find an alternative to :scope for relative Element hiding emulation filters

comment:2 Changed 2 years ago by kzar

  • Description modified (diff)

comment:3 Changed 14 months ago by hfiguiere

As it is, the alternative has been found by Microsoft now that they are cancelling EdgeHTML.

This bug will fix itself.

comment:4 Changed 10 months ago by mjethani

Since :scope is available on all platforms we support now (including the new Edge presumably), I think we can close this now.

comment:5 Changed 10 months ago by hfiguiere

Let's wait that Edge uses Chromium and that we can verify this is working.

comment:6 Changed 5 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Note: See TracTickets for help on using tickets.