Opened on 01/23/2018 at 04:50:21 PM

Closed on 08/29/2019 at 05:43:52 PM

#6304 closed change (rejected)

Find an alternative to :scope for relative Element hiding emulation filters

Reported by: hfiguiere Assignee:
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: mjethani, kzar, sergz, oleksandr Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


In order for relative selectors to work properly when combined with our special pseudo classes such as :abp-has we sometimes need to prefix selectors with the :scope CSS pseudo class (see #5436).

Unfortunately :scope is not yet supported by Microsoft Edge and therefore filters which use it are ignored.

What to change

  • Detect if :scope isn't available (querySelector() will throw an exception).
  • Switch to alternative method to build the selector if :scope isn't available, likely slower.
  • Ensure to run the test with both code path.


Attachments (0)

Change History (6)

comment:1 Changed on 01/24/2018 at 03:14:38 PM by kzar

  • Cc sergz oleksandr added
  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Edge
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Find an alternative to :scope in Element hiding emulation to Find an alternative to :scope for relative Element hiding emulation filters

comment:2 Changed on 01/24/2018 at 03:16:46 PM by kzar

  • Description modified (diff)

comment:3 Changed on 12/07/2018 at 10:38:14 AM by hfiguiere

As it is, the alternative has been found by Microsoft now that they are cancelling EdgeHTML.

This bug will fix itself.

comment:4 Changed on 03/17/2019 at 08:56:49 AM by mjethani

Since :scope is available on all platforms we support now (including the new Edge presumably), I think we can close this now.

comment:5 Changed on 03/18/2019 at 01:40:08 PM by hfiguiere

Let's wait that Edge uses Chromium and that we can verify this is working.

comment:6 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.