Opened 19 months ago

Closed 18 months ago

Last modified 17 months ago

#6309 closed change (fixed)

Start using SASS in adblockplusui

Reported by: saroyanm Assignee: agiammarchi
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, saroyanm Blocked By:
Blocking: #6117 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29712640

Description (last modified by agiammarchi)

Background

In order to organize CSS styles we would like to introduce SASS in adblockplusui, we decided to use SASS (rather than other tools), because websites team is also making use of SASS and that will help to easily adapt the websites-default.

What problem is this solving

SASS gives us the following opportunities:

  • we can use @import "module.scss"; to bundle modules together with the output
  • we can use $variable: value; to avoid issues with Edge 15

We might discuss the benefit of using any non standard SASS feature too, but for the time being we'll try to modularize CSS without bringing in non standard syntax (except for imports and/or variables, where appropriate).

What to change

Start using SASS.
[We still need to agree on task watcher/runner]

Change History (9)

comment:1 Changed 19 months ago by saroyanm

  • Blocking 6117 added

comment:2 Changed 19 months ago by greiner

  • Cc greiner added

comment:3 Changed 18 months ago by agiammarchi

  • Owner set to agiammarchi
  • Review URL(s) modified (diff)

comment:4 Changed 18 months ago by agiammarchi

  • Cc saroyanm added

comment:5 Changed 18 months ago by agiammarchi

  • Ready set

comment:6 Changed 18 months ago by agiammarchi

  • Description modified (diff)

comment:7 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 6309 - Start using SASS in adblockplusui

comment:8 Changed 18 months ago by agiammarchi

  • Resolution set to fixed
  • Status changed from new to closed

comment:9 Changed 17 months ago by Ross

Just noting: This has been started and does not look to have had any adverse effects on the builds.

Note: See TracTickets for help on using tickets.