Changes between Initial Version and Version 1 of Ticket #6310, comment 12


Ignore:
Timestamp:
03/23/2018 07:52:52 PM (3 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6310, comment 12

    initial v1  
    1414As much as autonomy is desired, `adblockplusui` is not a greenfield project. It has to integrate smoothly (on different levels) with `adblockpluschrome`. Merging the repositories seems to make this easier to enforce, while removing some overhead. But as long as we develop the UI in a separate repository, we have to make sure on a different level that our processes and infrastructure are aligned. 
    1515 
    16 Finally, regarding the change itself, I agree with kzar that the chosen approach doesn't quite fit in with our existing infrastructure. It seems compromises were made in favor to keep the integration on the `adblockpluschrome` side minimal. However, as long as they make sense and are documented, changes on our end in order to properly integrate a dependency are no concern, and in fact would have been much preferable over that Rube Goldberg machine approach that we ended up with. 
     16---- 
     17 
     18Regarding the change itself, I agree with kzar that the chosen approach doesn't quite fit in with our build process. It seems compromises were made in favor to keep the integration on the `adblockpluschrome` side minimal. However, as long as they make sense and are documented, changes on our end in order to properly integrate a dependency are no concern, and in fact would have been much preferable over that Rube Goldberg machine approach that we ended up with. 
    1719 
    1820Ideally, we'd like to see the `adblockpluschrome` and `adblockplusui` repositories merge, eliminating the need for integrating the UI as an external component, configuring UI modules along other modules we have in `adblockpluschrome` through our build configuration which uses webpack under the hood. 
     
    2022However, even with `adblockplusui` being developed in a separate repository, we could still configure modules through our module mechanism in `adblockpluschrome`, the same way `adblockpluscore` is integrated. This also has the advantage that all modules to be used in the same context end up in the same bundle regardless where they come from, and thanks to webpack we'd get source maps for free. 
    2123 
    22 Finally, if we really want to package the UI as an external component, the proper way seems to be creating an npm module (generated by webpack). But I'm uncertain if this direction is the way to go. However, FWIW, it would be at least a less hacky approach than what has been implemented now. 
     24Finally, if we really want to package the UI as an external component, the proper way seems to be generating an npm module with webpack. But I'm uncertain if this direction is the way to go. However, FWIW, it seems at least like a less hacky approach than what has been implemented now.