Opened 23 months ago

Closed 21 months ago

Last modified 20 months ago

#6315 closed change (fixed)

Fix gyp and gtest usage comment

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/8

Description (last modified by asmirnov)

Background

We have to build V8 with libadblockplus. For this we have to prepare deps including gtest and gyp.
We're having comment "/third_party/libadblockplus/prepare_dependencies.py" about it that is not very clear.

What to change

Fix comment for gyp and gtest usage for V8 deps:
https://codereview.adblockplus.org/29674555/#msg13

Tips for testers

Since it does not relate to any feature it's hard to test it (i'd say you can't test if you are not developer).
If Chromium can be compiled and launched it means it did not break it at least.

Change History (5)

comment:1 Changed 23 months ago by asmirnov

  • Description modified (diff)

comment:2 Changed 23 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 21 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed 21 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 20 months ago by asmirnov

  • Description modified (diff)
Note: See TracTickets for help on using tickets.