#6320 closed change (fixed)

Add summary for adblock setting

Reported by: jwangenheim Assignee: jwangenheim
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29684564/
https://codereview.adblockplus.org/29769575/

Description (last modified by jwangenheim)

Background

The AdblockWebView sample app also contains a settings page. All settings on that page have a summary/description, except the adblock enable/disable setting.

What to change

For consistency and to make sure people know what that settings is about (as the name is not very descriptive) we should also add a summary for his setting. We also should translate the summary in all available languages.

C&T said we should use the following wording:
Allow ad blocking on websites in this app

I already created a hub ticket for translations:
http://hub.eyeo.com/issues/7442

Attachments (1)

device-2018-01-30-131745.png (180.9 KB) - added by asmirnov 23 months ago.
scr after implementing

Download all attachments as: .zip

Change History (9)

comment:1 Changed 23 months ago by jwangenheim

  • Description modified (diff)

comment:2 Changed 23 months ago by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed 23 months ago by jwangenheim

  • Description modified (diff)

comment:4 Changed 23 months ago by asmirnov

  • Priority changed from Unknown to P3
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed 23 months ago by asmirnov

scr after implementing

comment:5 Changed 20 months ago by asmirnov

partly implemented in #6632

comment:6 Changed 20 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:7 Changed 19 months ago by abpbot

A commit referencing this issue has landed:
Issue 6320 - Add summary for adblock setting

comment:8 Changed 19 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.