Opened on 01/26/2018 at 01:18:28 PM

Closed on 05/11/2018 at 09:48:54 AM

#6320 closed change (fixed)

Add summary for adblock setting

Reported by: jwangenheim Assignee: jwangenheim
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by jwangenheim)


The AdblockWebView sample app also contains a settings page. All settings on that page have a summary/description, except the adblock enable/disable setting.

What to change

For consistency and to make sure people know what that settings is about (as the name is not very descriptive) we should also add a summary for his setting. We also should translate the summary in all available languages.

C&T said we should use the following wording:
Allow ad blocking on websites in this app

I already created a hub ticket for translations:

Attachments (1)

device-2018-01-30-131745.png (180.9 KB) - added by asmirnov on 01/30/2018 at 08:18:26 AM.
scr after implementing

Download all attachments as: .zip

Change History (9)

comment:1 Changed on 01/26/2018 at 03:17:16 PM by jwangenheim

  • Description modified (diff)

comment:2 Changed on 01/26/2018 at 03:25:00 PM by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed on 01/26/2018 at 03:28:22 PM by jwangenheim

  • Description modified (diff)

comment:4 Changed on 01/30/2018 at 08:11:46 AM by asmirnov

  • Priority changed from Unknown to P3
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed on 01/30/2018 at 08:18:26 AM by asmirnov

scr after implementing

comment:5 Changed on 05/03/2018 at 11:40:12 AM by asmirnov

partly implemented in #6632

comment:6 Changed on 05/03/2018 at 01:01:17 PM by asmirnov

  • Review URL(s) modified (diff)

comment:7 Changed on 05/11/2018 at 09:47:34 AM by abpbot

A commit referencing this issue has landed:
Issue 6320 - Add summary for adblock setting

comment:8 Changed on 05/11/2018 at 09:48:54 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
Note: See TracTickets for help on using tickets.