Opened 23 months ago

Closed 15 months ago

Last modified 5 months ago

#6323 closed change (fixed)

Move composer.html related files to adblockplusui

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: #6322, #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/129
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/6

Description (last modified by greiner)

Background

The filter composer dialog belongs to the User Interface module (albeit, it's still listed as "block.html") but the code for it is still located in adblockpluschrome. Therefore we want to move all its code to adblockplusui to be able to offer a more streamlined interface with the Web Extension team.

See also ui#203.

What to change

  • Move the following files from adblockpluschrome to adblockplusui:
    • composer.html
    • composer.js
  • Replace images in composer.html with skin/abp-logo.svg
  • Move styles in composer.html to new file at skin/composer.css

Notes for dependency update

  • Remove the following files from adblockpluschrome:
    • icons/detailed/abp-32.png.
    • composer.html
    • composer.js
  • Add mappings for the following files:
    • skin/composer.css
    • composer.html
    • composer.js

Change History (9)

comment:1 Changed 15 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

Actually, we now have various icons in adblockplusui that we could use instead so there should be no need anymore to move them over from adblockpluschrome.

comment:2 Changed 15 months ago by greiner

  • Description modified (diff)

Added link to GitLab issue.

comment:3 Changed 15 months ago by greiner

  • Description modified (diff)

comment:4 Changed 15 months ago by greiner

  • Owner set to greiner

comment:5 Changed 15 months ago by greiner

  • Blocking 6936 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 15 months ago by greiner

  • Description modified (diff)

Updated ticket description to reflect decision that was made in review to drop jQuery UI.

comment:8 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 6323 - Moved composer from adblockpluschrome

comment:9 Changed 5 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.