Opened 20 months ago

Closed 12 months ago

Last modified 2 months ago

#6324 closed change (fixed)

Move messageResponder.js to lib directory

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6322, #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/132
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/7

Description (last modified by greiner)

Background

We want to establish a more organized file structure for the adblockplusui repository. For that we want to clearly separate code that's imported into the background page from logic in UI pages or mock logic. The former should be located in the already existing "lib" directory and the only outlier to that rule is "messageResponder.js" which is why we could easily make this consistent.

See also ui#204.

What to change

  • Move messageResponder.js to lib/ directory
  • Updated reference in background.html

Notes for dependency update

  • Mapping for messageResponder.js needs to be updated to point to adblockplusui/lib/messageResponder.js

Change History (7)

comment:1 Changed 12 months ago by greiner

  • Owner set to greiner

comment:2 Changed 12 months ago by greiner

  • Description modified (diff)

comment:3 Changed 12 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 10 months ago by greiner

  • Blocking 6936 added

comment:6 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 6324 - Moved message responder to lib directory

comment:7 Changed 2 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.