Opened on 01/26/2018 at 02:48:24 PM

Closed on 09/25/2018 at 06:04:03 PM

Last modified on 07/10/2019 at 12:15:32 PM

#6324 closed change (fixed)

Move messageResponder.js to lib directory

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6322, #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by greiner)


We want to establish a more organized file structure for the adblockplusui repository. For that we want to clearly separate code that's imported into the background page from logic in UI pages or mock logic. The former should be located in the already existing "lib" directory and the only outlier to that rule is "messageResponder.js" which is why we could easily make this consistent.

See also ui#204.

What to change

  • Move messageResponder.js to lib/ directory
  • Updated reference in background.html

Notes for dependency update

  • Mapping for messageResponder.js needs to be updated to point to adblockplusui/lib/messageResponder.js

Attachments (0)

Change History (7)

comment:1 Changed on 09/25/2018 at 04:39:00 PM by greiner

  • Owner set to greiner

comment:2 Changed on 09/25/2018 at 04:40:53 PM by greiner

  • Description modified (diff)

comment:3 Changed on 09/25/2018 at 04:48:43 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/23/2018 at 01:02:48 PM by greiner

  • Blocking 6936 added

comment:6 Changed on 05/20/2019 at 10:58:26 AM by abpbot

A commit referencing this issue has landed:
Issue 6324 - Moved message responder to lib directory

comment:7 Changed on 07/10/2019 at 12:15:32 PM by ukacar

  • Verified working set

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.