#6325 closed change (worksforme)

Remove WOFF fonts in favor of WOFF2 variants

Reported by: greiner Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: jeen Blocked By:
Blocking: #6327 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

We have both WOFF as well as WOFF2 variants of the Source Sans Pro font in adblockplusui. However, according to MDN all relevant browsers already support WOFF2 so there should be no need to keep the WOFF files around anymore.

What to change

  • Remove skin/fonts/SourceSansPro-{bold,Light,Regular}.woff
  • Replace references with skin/fonts/Source-Sans-Pro/{300,400,700}.woff2

Notes for dependency update

  • Remove mappings for skin/fonts/SourceSansPro-{bold,Light,Regular}.woff files

Change History (7)

comment:1 Changed 23 months ago by greiner

  • Description modified (diff)

Added notes for dependency update

comment:2 Changed 23 months ago by greiner

  • Blocking 6327 added; 6322 removed

comment:3 Changed 23 months ago by greiner

  • Priority changed from Unknown to P3

comment:4 Changed 22 months ago by saroyanm

  • Cc jeen added

This is already/almost fixed with #6209, as we have introduced Source Sans Pro subsets, the folder structure currently is:

skin/fonts/Source-Sans-Pro/
├── 300
│   ├── cyrillic-ext.woff2
│   ├── cyrillic.woff2
│   ├── greek-ext.woff2
│   ├── greek.woff2
│   ├── latin-ext.woff2
│   ├── latin.woff2
│   └── vietnamese.woff2
├── 400
│   ├── cyrillic-ext.woff2
│   ├── cyrillic.woff2
│   ├── greek-ext.woff2
│   ├── greek.woff2
│   ├── latin-ext.woff2
│   ├── latin.woff2
│   └── vietnamese.woff2
├── 700
│   ├── cyrillic-ext.woff2
│   ├── cyrillic.woff2
│   ├── greek-ext.woff2
│   ├── greek.woff2
│   ├── latin-ext.woff2
│   ├── latin.woff2
│   └── vietnamese.woff2
└── LICENSE.txt

The only thing is left is that first-run page is using CreteRound, I'm wondering if I can change that font to the Source-Sans-Pro and we will have a clear font structure here..
@Jeen, @Thomas: Can I change current fonts of first-run page to Source-Sans-Pro (I'm not sure how long it will take for the first run page redesign to be done) ?

comment:5 Changed 22 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

Nevermind, I think we don't have to be rush here, anyway I have updated the proposed structure as well -> I thinnk this ticket can now be closed.

comment:6 Changed 22 months ago by saroyanm

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 22 months ago by saroyanm

  • Resolution set to worksforme
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.